Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make chunk and batch proposers respect fork boundaries #1174

Merged
merged 12 commits into from
Mar 6, 2024

Conversation

omerfirmak
Copy link
Contributor

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@omerfirmak omerfirmak marked this pull request as ready for review March 4, 2024 08:13
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 57.22%. Comparing base (63f1b1e) to head (bf1c739).

Files Patch % Lines
rollup/internal/config/config.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1174      +/-   ##
===========================================
+ Coverage    57.04%   57.22%   +0.17%     
===========================================
  Files          153      154       +1     
  Lines        11115    11183      +68     
===========================================
+ Hits          6341     6399      +58     
- Misses        4326     4336      +10     
  Partials       448      448              
Flag Coverage Δ
common 60.49% <100.00%> (+1.18%) ⬆️
coordinator 20.26% <ø> (ø)
database 42.85% <ø> (ø)
rollup 66.54% <72.97%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omerfirmak omerfirmak force-pushed the omerfirmak/chunk-batch-forks branch from 0c96c2f to 6874c01 Compare March 4, 2024 08:20
@omerfirmak omerfirmak marked this pull request as draft March 4, 2024 09:07
@omerfirmak omerfirmak force-pushed the omerfirmak/chunk-batch-forks branch from 6874c01 to 9e89c65 Compare March 4, 2024 09:17
@omerfirmak omerfirmak marked this pull request as ready for review March 4, 2024 09:23
@omerfirmak omerfirmak force-pushed the omerfirmak/chunk-batch-forks branch from 330a717 to e661f67 Compare March 4, 2024 09:51
@omerfirmak omerfirmak force-pushed the omerfirmak/chunk-batch-forks branch from e661f67 to 285505f Compare March 4, 2024 10:33
@omerfirmak omerfirmak force-pushed the omerfirmak/chunk-batch-forks branch from 285505f to a3824db Compare March 4, 2024 10:51
@omerfirmak omerfirmak marked this pull request as draft March 4, 2024 11:05
@omerfirmak omerfirmak marked this pull request as draft March 4, 2024 11:05
@omerfirmak omerfirmak force-pushed the omerfirmak/chunk-batch-forks branch from a3824db to 9c53347 Compare March 4, 2024 11:15
@omerfirmak omerfirmak marked this pull request as ready for review March 4, 2024 11:16
@omerfirmak omerfirmak force-pushed the omerfirmak/chunk-batch-forks branch 5 times, most recently from 2964e42 to e3ce0b8 Compare March 4, 2024 16:24
@omerfirmak omerfirmak force-pushed the omerfirmak/chunk-batch-forks branch from ff915ce to 936ea0a Compare March 5, 2024 15:34
@omerfirmak omerfirmak force-pushed the omerfirmak/chunk-batch-forks branch from 936ea0a to e608c6b Compare March 5, 2024 15:54
colinlyguo
colinlyguo previously approved these changes Mar 6, 2024
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments, and the refactor comments are the same as @georgehao.

@georgehao
Copy link
Member

georgehao commented Mar 6, 2024

BTW, I will checkout your branch to write coordinator logic: assign task to multi version prover, because I want reuse your forks common logic. Pls don't use hard push. Thx, hahaha

@georgehao georgehao merged commit 96179d1 into develop Mar 6, 2024
21 checks passed
@georgehao georgehao deleted the omerfirmak/chunk-batch-forks branch March 6, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants