-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make chunk and batch proposers respect fork boundaries #1174
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1174 +/- ##
===========================================
+ Coverage 57.04% 57.22% +0.17%
===========================================
Files 153 154 +1
Lines 11115 11183 +68
===========================================
+ Hits 6341 6399 +58
- Misses 4326 4336 +10
Partials 448 448
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0c96c2f
to
6874c01
Compare
6874c01
to
9e89c65
Compare
330a717
to
e661f67
Compare
e661f67
to
285505f
Compare
285505f
to
a3824db
Compare
a3824db
to
9c53347
Compare
2964e42
to
e3ce0b8
Compare
ff915ce
to
936ea0a
Compare
936ea0a
to
e608c6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some comments, and the refactor comments are the same as @georgehao.
BTW, I will checkout your branch to write coordinator logic: |
Purpose or design rationale of this PR
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?