Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge-history): change FinalizeBatch event logic #1405

Merged
merged 15 commits into from
Jul 1, 2024

Conversation

amoylan2
Copy link
Contributor

Purpose or design rationale of this PR

Upgrade the logic when dealing with FinalizeBatch event.
This is intended to support darwin as well as backward compatible.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • [] No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@amoylan2
Copy link
Contributor Author

This is a mirror of #1404 with target to develop branch

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.31%. Comparing base (a2536d5) to head (dfaad05).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1405   +/-   ##
========================================
  Coverage    54.31%   54.31%           
========================================
  Files          156      156           
  Lines        11918    11918           
========================================
  Hits          6473     6473           
  Misses        4950     4950           
  Partials       495      495           
Flag Coverage Δ
bridge-history-api 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amoylan2 amoylan2 force-pushed the feat/upgrade4_bridge_history_develop branch from f4bae0a to 74c953d Compare June 28, 2024 12:42
colinlyguo
colinlyguo previously approved these changes Jun 28, 2024
@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Jun 28, 2024
@colinlyguo colinlyguo requested a review from 0xmountaintop July 1, 2024 07:18
@amoylan2 amoylan2 merged commit 16673e2 into develop Jul 1, 2024
5 checks passed
@amoylan2 amoylan2 deleted the feat/upgrade4_bridge_history_develop branch July 1, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants