Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bridge-history-backend): track reset skipped message events #1467

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jul 29, 2024

Purpose or design rationale of this PR

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.30%. Comparing base (d163abe) to head (46d50a4).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1467      +/-   ##
===========================================
+ Coverage    53.27%   53.30%   +0.02%     
===========================================
  Files          155      155              
  Lines        11774    11762      -12     
===========================================
- Hits          6273     6270       -3     
+ Misses        5006     4997       -9     
  Partials       495      495              
Flag Coverage Δ
bridge-history-api 71.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colinlyguo colinlyguo added the bump-version Bump the version tag for deployment label Jul 30, 2024
@colinlyguo colinlyguo requested a review from 0xmountaintop July 30, 2024 07:54
zimpha
zimpha previously approved these changes Jul 30, 2024
@colinlyguo colinlyguo merged commit dd6206f into develop Jul 30, 2024
5 checks passed
@colinlyguo colinlyguo deleted the feat-bridge-history-backend-track-reset-skipped-message-events branch July 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants