feat(relayer): adapt to CodecV7 for EuclidV2 #1583
+1,104
−121
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -373,11 +373,156 @@ func (r *Layer2Relayer) ProcessGasPriceOracle() { | |
| // ProcessPendingBatches processes the pending batches by sending commitBatch transactions to layer 1. | ||
| func (r *Layer2Relayer) ProcessPendingBatches() { | ||
| // get pending batches from database in ascending order by their index. | ||
| dbBatches, err := r.batchOrm.GetFailedAndPendingBatches(r.ctx, max(5, r.cfg.SenderConfig.BatchSubmission.MaxBatches)) | ||
| if err != nil { | ||
| log.Error("Failed to fetch pending L2 batches", "err", err) | ||
| return | ||
| } | ||
|
|
||
| var batchesToSubmit []*dbBatchWithChunksAndParent | ||
| var forceSubmit bool | ||
| for i, dbBatch := range dbBatches { | ||
| if i == 0 && encoding.CodecVersion(dbBatch.CodecVersion) < encoding.CodecV6 { | ||
| // if the first batch is not >= V6 then we need to submit batches one by one | ||
colinlyguo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| r.processPendingBatchesV4(dbBatches) | ||
| return | ||
| } | ||
|
|
||
| batchesToSubmitLen := len(batchesToSubmit) | ||
| var dbChunks []*orm.Chunk | ||
| var dbParentBatch *orm.Batch | ||
|
|
||
| // Verify batches compatibility | ||
| { | ||
jonastheis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| dbChunks, err = r.chunkOrm.GetChunksInRange(r.ctx, dbBatch.StartChunkIndex, dbBatch.EndChunkIndex) | ||
| if err != nil { | ||
| log.Error("failed to get chunks in range", "err", err) | ||
| return | ||
| } | ||
|
|
||
| // check codec version | ||
| for _, dbChunk := range dbChunks { | ||
| if dbBatch.CodecVersion != dbChunk.CodecVersion { | ||
| log.Error("batch codec version is different from chunk codec version", "batch index", dbBatch.Index, "chunk index", dbChunk.Index, "batch codec version", dbBatch.CodecVersion, "chunk codec version", dbChunk.CodecVersion) | ||
| return | ||
| } | ||
| } | ||
|
|
||
| if dbBatch.Index == 0 { | ||
|
There was a problem hiding this comment. when we build a new network (eg: devnet by CodecV7), I think this will make the There was a problem hiding this comment. it's the same check that is applied for Also my understanding is that batch 0 is committed in . |
||
| log.Error("invalid args: batch index is 0, should only happen in committing genesis batch") | ||
| return | ||
| } | ||
|
|
||
| dbParentBatch, err = r.batchOrm.GetBatchByIndex(r.ctx, dbBatch.Index-1) | ||
|
There was a problem hiding this comment. Most of these batches are already in memory ( There was a problem hiding this comment. changed to use |
||
| if err != nil { | ||
| log.Error("failed to get parent batch header", "err", err) | ||
| return | ||
| } | ||
|
|
||
| if dbParentBatch.CodecVersion > dbBatch.CodecVersion { | ||
| log.Error("parent batch codec version is greater than current batch codec version", "index", dbBatch.Index, "hash", dbBatch.Hash, "parent codec version", dbParentBatch.CodecVersion, "current codec version", dbBatch.CodecVersion) | ||
| return | ||
| } | ||
|
|
||
| // make sure we commit batches of the same codec version together. | ||
| // If we encounter a batch with a different codec version, we stop here and will commit the batches we have so far. | ||
| // The next call of ProcessPendingBatches will then start with the batch with the different codec version. | ||
| if batchesToSubmitLen > 0 && batchesToSubmit[batchesToSubmitLen-1].Batch.CodecVersion != dbBatch.CodecVersion { | ||
jonastheis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| break | ||
| } | ||
| } | ||
|
|
||
| // if one of the batches is too old, we force submit all batches that we have so far in the next step | ||
| if !forceSubmit && time.Since(dbBatch.CreatedAt) > time.Duration(r.cfg.SenderConfig.BatchSubmission.TimeoutSec)*time.Second { | ||
| forceSubmit = true | ||
| } | ||
|
|
||
| if batchesToSubmitLen <= r.cfg.SenderConfig.BatchSubmission.MaxBatches { | ||
| batchesToSubmit = append(batchesToSubmit, &dbBatchWithChunksAndParent{ | ||
| Batch: dbBatch, | ||
| Chunks: dbChunks, | ||
| ParentBatch: dbParentBatch, | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| if !forceSubmit && len(batchesToSubmit) < r.cfg.SenderConfig.BatchSubmission.MinBatches { | ||
|
There was a problem hiding this comment. Why here is There was a problem hiding this comment. it's checking whether we have enough batches to be committed. we only submit batches if we have a timeout or if we have enough batches ( |
||
| log.Debug("Not enough batches to submit", "count", len(batchesToSubmit), "minBatches", r.cfg.SenderConfig.BatchSubmission.MinBatches, "maxBatches", r.cfg.SenderConfig.BatchSubmission.MaxBatches) | ||
jonastheis marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return | ||
| } | ||
|
|
||
| if forceSubmit { | ||
| log.Info("Forcing submission of batches due to timeout", "batch index", batchesToSubmit[0].Batch.Index, "created at", batchesToSubmit[0].Batch.CreatedAt) | ||
| } | ||
|
|
||
| // We have at least 1 batch to commit | ||
| firstBatch := batchesToSubmit[0].Batch | ||
| lastBatch := batchesToSubmit[len(batchesToSubmit)-1].Batch | ||
|
|
||
| codecVersion := encoding.CodecVersion(firstBatch.CodecVersion) | ||
| switch codecVersion { | ||
| case encoding.CodecV6: | ||
| calldata, blob, err := r.constructCommitBatchPayloadCodecV6(batchesToSubmit) | ||
| if err != nil { | ||
| log.Error("failed to construct commitBatchWithBlobProof payload for V6", "codecVersion", codecVersion, "start index", firstBatch.Index, "end index", lastBatch.Index, "err", err) | ||
| return | ||
| } | ||
| default: | ||
| log.Error("unsupported codec version in ProcessPendingBatches", "codecVersion", codecVersion, "start index", firstBatch, "end index", lastBatch.Index) | ||
| return | ||
| } | ||
|
|
||
| //txHash, err := r.commitSender.SendTransaction(dbBatch.Hash, &r.cfg.RollupContractAddress, calldata, blob, 0) | ||
| //if err != nil { | ||
| // if errors.Is(err, sender.ErrTooManyPendingBlobTxs) { | ||
| // r.metrics.rollupL2RelayerProcessPendingBatchErrTooManyPendingBlobTxsTotal.Inc() | ||
| // log.Debug( | ||
| // "Skipped sending commitBatch tx to L1: too many pending blob txs", | ||
| // "maxPending", r.cfg.SenderConfig.MaxPendingBlobTxs, | ||
| // "err", err, | ||
| // ) | ||
| // return | ||
| // } | ||
| // log.Error( | ||
| // "Failed to send commitBatch tx to layer1", | ||
| // "index", dbBatch.Index, | ||
| // "hash", dbBatch.Hash, | ||
| // "RollupContractAddress", r.cfg.RollupContractAddress, | ||
| // "err", err, | ||
| // "calldata", common.Bytes2Hex(calldata), | ||
| // ) | ||
| // return | ||
| //} | ||
| // | ||
| //err = r.batchOrm.UpdateCommitTxHashAndRollupStatus(r.ctx, dbBatch.Hash, txHash.String(), types.RollupCommitting) | ||
| //if err != nil { | ||
| // log.Error("UpdateCommitTxHashAndRollupStatus failed", "hash", dbBatch.Hash, "index", dbBatch.Index, "err", err) | ||
| // return | ||
| //} | ||
| // | ||
| //var maxBlockHeight uint64 | ||
| //var totalGasUsed uint64 | ||
| //for _, dbChunk := range dbChunks { | ||
| // if dbChunk.EndBlockNumber > maxBlockHeight { | ||
| // maxBlockHeight = dbChunk.EndBlockNumber | ||
| // } | ||
| // totalGasUsed += dbChunk.TotalL2TxGas | ||
| //} | ||
| //r.metrics.rollupL2RelayerCommitBlockHeight.Set(float64(maxBlockHeight)) | ||
| //r.metrics.rollupL2RelayerCommitThroughput.Add(float64(totalGasUsed)) | ||
| // | ||
| //r.metrics.rollupL2RelayerProcessPendingBatchSuccessTotal.Inc() | ||
| //log.Info("Sent the commitBatch tx to layer1", "batch index", dbBatch.Index, "batch hash", dbBatch.Hash, "tx hash", txHash.String()) | ||
|
|
||
| } | ||
|
|
||
| type dbBatchWithChunksAndParent struct { | ||
| Batch *orm.Batch | ||
| Chunks []*orm.Chunk | ||
| ParentBatch *orm.Batch | ||
| } | ||
|
|
||
| func (r *Layer2Relayer) processPendingBatchesV4(dbBatches []*orm.Batch) { | ||
| for _, dbBatch := range dbBatches { | ||
| r.metrics.rollupL2RelayerProcessPendingBatchTotal.Inc() | ||
|
|
||
|
|
@@ -432,7 +577,7 @@ func (r *Layer2Relayer) ProcessPendingBatches() { | |
| return | ||
| } | ||
| default: | ||
| log.Error("unsupported codec version in processPendingBatchesV4", "codecVersion", codecVersion) | ||
| return | ||
| } | ||
|
|
||
|
|
@@ -868,6 +1013,64 @@ func (r *Layer2Relayer) constructCommitBatchPayloadCodecV4(dbBatch *orm.Batch, d | |
| return calldata, daBatch.Blob(), nil | ||
| } | ||
|
|
||
| func (r *Layer2Relayer) constructCommitBatchPayloadCodecV6(batchesToSubmit []*dbBatchWithChunksAndParent) ([]byte, []*kzg4844.Blob, error) { | ||
| blobs := make([]*kzg4844.Blob, len(batchesToSubmit)) | ||
|
|
||
| version := encoding.CodecVersion(batchesToSubmit[0].Batch.CodecVersion) | ||
| var firstParentBatch *orm.Batch | ||
| // construct blobs | ||
| for _, b := range batchesToSubmit { | ||
| // double check that all batches have the same version | ||
| batchVersion := encoding.CodecVersion(b.Batch.CodecVersion) | ||
| if batchVersion != version { | ||
| return nil, nil, fmt.Errorf("codec version mismatch, expected: %d, got: %d for batches %d and %d", version, batchVersion, batchesToSubmit[0].Batch.Index, b.Batch.Index) | ||
| } | ||
|
|
||
| if firstParentBatch == nil { | ||
| firstParentBatch = b.ParentBatch | ||
| } | ||
|
|
||
| chunks := make([]*encoding.Chunk, len(b.Chunks)) | ||
| for i, c := range b.Chunks { | ||
| blocks, err := r.l2BlockOrm.GetL2BlocksInRange(r.ctx, c.StartBlockNumber, c.EndBlockNumber) | ||
| if err != nil { | ||
| return nil, nil, fmt.Errorf("failed to get blocks in range for batch %d: %w", b.Batch.Index, err) | ||
| } | ||
| chunks[i] = &encoding.Chunk{Blocks: blocks} | ||
| } | ||
|
|
||
| encodingBatch := &encoding.Batch{ | ||
| Index: b.Batch.Index, | ||
| TotalL1MessagePoppedBefore: b.Chunks[0].TotalL1MessagesPoppedBefore, | ||
| ParentBatchHash: common.HexToHash(b.ParentBatch.Hash), | ||
| Chunks: chunks, | ||
| } | ||
|
|
||
| codec, err := encoding.CodecFromVersion(version) | ||
| if err != nil { | ||
| return nil, nil, fmt.Errorf("failed to get codec from version %d, err: %w", b.Batch.CodecVersion, err) | ||
| } | ||
|
|
||
| daBatch, err := codec.NewDABatch(encodingBatch) | ||
| if err != nil { | ||
| return nil, nil, fmt.Errorf("failed to create DA batch: %w", err) | ||
| } | ||
|
|
||
| blobs = append(blobs, daBatch.Blob()) | ||
| } | ||
|
|
||
| if firstParentBatch == nil { | ||
| return nil, nil, fmt.Errorf("firstParentBatch is nil") | ||
| } | ||
|
|
||
| // TODO: this needs to be updated once the contract interface is finalized | ||
| calldata, err := r.l1RollupABI.Pack("commitBatches", version, firstParentBatch.BatchHeader) | ||
| if err != nil { | ||
| return nil, nil, fmt.Errorf("failed to pack commitBatchWithBlobProof: %w", err) | ||
| } | ||
| return calldata, blobs, nil | ||
| } | ||
|
|
||
| func (r *Layer2Relayer) constructFinalizeBundlePayloadCodecV4(dbBatch *orm.Batch, aggProof *message.BundleProof) ([]byte, error) { | ||
| if aggProof != nil { // finalizeBundle with proof. | ||
| calldata, packErr := r.l1RollupABI.Pack( | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove 5, and use config value only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in fbc14ac. also added some sanity checks on startup to make sure it is always set to at least 1