Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add complete ChunkInfo #76

Closed
wants to merge 1 commit into from
Closed

feat: add complete ChunkInfo #76

wants to merge 1 commit into from

Conversation

lightsing
Copy link
Member

@lightsing lightsing commented Jan 22, 2025

batch circuit needs this type

@lightsing lightsing requested review from lispc and noel2004 January 22, 2025 07:19
Copy link
Member

@noel2004 noel2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel not quite confident to export ChunkInfo from sbv for common used by crates in prover, with following reasons:

  1. sbv do not really need this structure to be well defined inside of it (it is prover who need it)
  2. if ChunkInfo is exported from sbv, any zkvm circuit (batch or even bundle) need to depend on sbv, which would be rather heavy since sbv (basically yet another reth) has induced a lot of openvm's extension so any circuits depend on sbv require many extra setups like here.

Further reflection: The information in ChunkInfo is what prover expected to known from sbv after it has been executed (as sproll-evm's program), maybe such a scheme would be better:

  1. sbv export its ChunkInfo, with defination at its convenience, but should include data which have to be known explicitily by the upper level (batch / bundle): state_root, withdraw_root, chunk_index, etc

  2. prover would export another ChunkInfo to be shared between circuits

@lightsing lightsing closed this Jan 23, 2025
@lightsing
Copy link
Member Author

won't merge

@lightsing lightsing deleted the feat/chunk-info branch January 23, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants