Correct bitstream decoding idx

scroll-tech · May 14, 2024 · 284acfe · 284acfe
1 parent a315012
commit 284acfe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/aggregator/src/aggregation/decoder.rs b/aggregator/src/aggregation/decoder.rs
@@ -4646,7 +4646,7 @@ impl DecoderConfig {
                             || "byte_idx",
                             self.byte_idx,
                             idx,
-                            || Value::known(Fr::from(last_byte_idx as u64)),
+                            || Value::known(Fr::from(last_byte_idx + 1 as u64)),
                         )?;
                         padding_count -= 1;
                     }

diff --git a/aggregator/src/aggregation/decoder/witgen.rs b/aggregator/src/aggregation/decoder/witgen.rs
@@ -1497,15 +1497,9 @@ fn process_sequences<F: Field>(
                 (current_byte_idx, current_bit_idx) = increment_idx(current_byte_idx, current_bit_idx);
             }
         } else if nb > 0 && next_nb == 0 {
-            if to_bit_idx == 7 || to_bit_idx == 15 || to_bit_idx == 23 {  
-                tail_holding_bit = true; 
-                for _ in 0..(nb - skipped_bits - 1) {
-                    (current_byte_idx, current_bit_idx) = increment_idx(current_byte_idx, current_bit_idx);
-                }
-            } else {
-                for _ in 0..(nb - skipped_bits) {
-                    (current_byte_idx, current_bit_idx) = increment_idx(current_byte_idx, current_bit_idx);
-                }
+            tail_holding_bit = true; 
+            for _ in 0..(nb - skipped_bits - 1) {
+                (current_byte_idx, current_bit_idx) = increment_idx(current_byte_idx, current_bit_idx);
             }
         } else if nb == 0 && next_nb > 0 {
             if tail_holding_bit {