add comment for rlp_unsigned_bytes

scroll-tech · Jul 18, 2024 · e05ccdc · e05ccdc
1 parent 6f199a1
commit e05ccdc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/bus-mapping/src/circuit_input_builder/transaction.rs b/bus-mapping/src/circuit_input_builder/transaction.rs
@@ -194,7 +194,8 @@ pub struct Transaction {
     pub signature: Signature,
     /// RLP bytes
     pub rlp_bytes: Vec<u8>,
-    /// RLP bytes for signing
+    /// RLP bytes for signing, only used for PreEip155 tx without chainid
+    /// for other tx types: rlp == rlp_unsigned.
     pub rlp_unsigned_bytes: Vec<u8>,
     /// RLP bytes for signed tx
     pub rlp_signed_bytes: Vec<u8>,

diff --git a/eth-types/src/geth_types.rs b/eth-types/src/geth_types.rs
@@ -287,7 +287,8 @@ pub struct Transaction {
 
     /// RLP bytes
     pub rlp_bytes: Vec<u8>,
-    /// RLP unsigned bytes
+    /// RLP unsigned bytes, only used for PreEip155 tx without chainid
+    /// for other tx types: rlp == rlp_unsigned.
     pub rlp_unsigned_bytes: Vec<u8>,
     // TODO: add rlp_signed_bytes as well ?
     /// Transaction hash