forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
epic: Blob 4844 DA #1153
Merged
Merged
epic: Blob 4844 DA #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Uncomment tests and add coefficient endianness test * Remove unneeded std::iter::empty calls * import once and repeat * Move point precompile tests to barycentric file * clippy --------- Co-authored-by: Mason Liang <[email protected]>
* Give constants more descriptive names and comments * rephrase comment --------- Co-authored-by: Mason Liang <[email protected]> Co-authored-by: Rohit Narurkar <[email protected]>
z2trillion
reviewed
Apr 2, 2024
* Remove individual L2 tx hash from keccak * Recheck l1 hash * Constrain l2 tx hash 0
confirmed: the last commit 4f5c3bb does not affect vk. |
…uits into feat/blob-4844-da
lispc
reviewed
Apr 6, 2024
lispc
reviewed
Apr 6, 2024
lispc
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
crate-bus-mapping
crate-eth-types
crate-prover
crate-zkevm-circuits
da-4844
Changes required to support DA via blobs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EIP-4844 Blob DA