Audit Fixes EIP2930/1559 RLP Decoding Table Correspondence #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunxian-xia
reviewed
Apr 10, 2024
kunxian-xia
reviewed
Apr 12, 2024
kunxian-xia
reviewed
Apr 18, 2024
kunxian-xia
approved these changes
Apr 19, 2024
lispc
added a commit
that referenced
this pull request
Apr 24, 2024
* Correct typo * Correct RLC * Change tag column status * Add tx_nonce consistency * Remove vestige gadget * Add v constraint for 1559/2930 * Constrain depth consistency for fsm state transition * Correct q_first query for initial num_all_txs_acc condition * Ensure continuity of sectional flag is_calldata and is_access_list * Remove tx unchanged constraint for dynamic sectional transition * Add tx_id constraints in dynamic section * Constrain access list tx table fields according to AccessListAddressLen * Constrain is_padding_tx * Add constraint for id calculation in rlp_decoding_table * Remove redundant boolean requirements * Add init condition for access_list_idx and storage_key_idx * Turn on value_is_zero for access list len * Remove whitespace * Add byte_idx to PUSH/POP lookup correspondence * fmt * Update cargo * Resolve build issues * fmt and clippy * Recover tests * Correct gate name * Remove debug flags * fmt * cargo * Revert ethers-core branch * cargo * Restrict booleans * fmt * Audit Fixes EIP2930/1559 RLP Decoding Table Correspondence (#1181) * Remove debug flags * Add decoding table PUSH lookup correspondence * Complete Stack Op Correspondence * fmt * Correct lookup constraint * Remove unused macro * fmt * Correct lookup constraint for pre 2930 txs * fmt * Adjust comments * fmt * Add lookup indicator column for state machine * Add correct condition for stack op lookups * Complete PUSH op lookup * Correct POP op lookup * Correct PUSH lookup * fmt * Add backward compatibility for eip155 and pre155 * Add al_idx to input expression * Add access list idx to PUSH correspondence --------- Co-authored-by: DreamWuGit <[email protected]> * Audit Fixes EIP2930/1559 TxCircuit Dynamic Section Transitions (#1176) * Refactor tx circuit dynamic section after introducing access list * Adjust comments * fmt * Column naming --------- Co-authored-by: DreamWuGit <[email protected]> --------- Co-authored-by: DreamWuGit <[email protected]> Co-authored-by: Zhang Zhuo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a major issue in RLP audit that raises concern for malicious RLP stack op injection into the decoding table. The fix includes lookups from the sorted decoding table into
rlp_tableand RLP state machine to ensure row correspondence.Type of change