Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2930 signature & add tests #1199

Merged
merged 12 commits into from
Apr 10, 2024
Merged

fix 2930 signature & add tests #1199

merged 12 commits into from
Apr 10, 2024

Conversation

DreamWuGit
Copy link
Member

@DreamWuGit DreamWuGit commented Apr 3, 2024

Description

  • fix signature issue for 2930, similar to 1559 signature problem.
  • add tests for 2930
    • empty access list
    • non empty access list (address + storage key)
    • only address without storage key list

Issue Link

issue #1185

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@DreamWuGit
Copy link
Member Author

mark ready for ci testing...

@DreamWuGit DreamWuGit marked this pull request as ready for review April 9, 2024 06:41
@lispc lispc merged commit 0e5cf47 into develop Apr 10, 2024
15 checks passed
@lispc lispc deleted the 2930_fix branch April 10, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants