Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4844 soundness tests #1210

Merged
merged 15 commits into from
Apr 13, 2024
Merged

Add 4844 soundness tests #1210

merged 15 commits into from
Apr 13, 2024

Conversation

z2trillion
Copy link
Member

@z2trillion z2trillion commented Apr 11, 2024

Add soundness tests that check that the circuit does not verify if cells are incorrectly assigned.

@z2trillion z2trillion added the da-4844 Changes required to support DA via blobs label Apr 11, 2024
@z2trillion z2trillion changed the title Add soundness tests Add 4844 soundness tests Apr 11, 2024
@z2trillion z2trillion marked this pull request as ready for review April 11, 2024 16:19
@lispc
Copy link

lispc commented Apr 12, 2024

some conflicts

Copy link

@roynalnaruto roynalnaruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@roynalnaruto roynalnaruto merged commit c0a5677 into develop Apr 13, 2024
15 checks passed
@roynalnaruto roynalnaruto deleted the feat/soundness_rebase branch April 13, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
da-4844 Changes required to support DA via blobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants