L1 Fee Curie: add unit test #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-circuits into curie_unittest
…-circuits into curie_unittest
|
@DreamWuGit can merge develop |
|
will fix new test failure |
|
@lispc ready now. |
lispc
reviewed
Jun 5, 2024
lispc
reviewed
Jun 5, 2024
lispc
reviewed
Jun 5, 2024
| .assign(region, 0, Value::known(F::from(is_curie)))?; | ||
| let rlp_signed_len = if is_curie == 1 { tx_signed_length } else { 0 }; | ||
| self.tx_signed_length | ||
| .assign(region, 0, Value::known(F::from(rlp_signed_len)))?; |
There was a problem hiding this comment.
i think it is ok to still assign tx_signed_length even when is_curie == 0? Not used anyway
There was a problem hiding this comment.
in begin_tx , this tx_signed_length is looked up from tx table, so can not be any value eventually in real circuit even not is_curie.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update
TxL1FeeGadgetTestContainerto support Curie l1 fee unit testsIssue Link
[link issue here]
Type of change