Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auditing: ErrorMemorycopy constrain src_len & memory expansion #1321

Merged
merged 15 commits into from
Jun 11, 2024
Merged

Auditing: ErrorMemorycopy constrain src_len & memory expansion #1321

merged 15 commits into from
Jun 11, 2024

Conversation

DreamWuGit
Copy link
Member

@DreamWuGit DreamWuGit commented Jun 4, 2024 •
edited
Loading

Description

fix two issues

  • constrain src_len = dst_len for mcopy
  • memory expansion for mcopy like mcopy gadget.

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@DreamWuGit DreamWuGit changed the title Auditting: ErrorMemorycopy constrain src_len = dst_len Auditing: ErrorMemorycopy constrain src_len = dst_len Jun 4, 2024
@DreamWuGit
Copy link
Member Author

mark ready for testing..

@DreamWuGit DreamWuGit marked this pull request as ready for review June 5, 2024 13:17
@DreamWuGit DreamWuGit changed the title Auditing: ErrorMemorycopy constrain src_len = dst_len Auditing: ErrorMemorycopy constrain src_len & memory expansion Jun 6, 2024
@DreamWuGit
Merge branch 'develop' into audit_memory_copy
79e7329
@DreamWuGit
Auditing improvement: test new_for_mcopy (#1326)
c1654c6 
* improve test new_for_mcopy

* adjust next_memory_word_size

* remove comment

* update cur_memory_word_size zero
@lispc lispc merged commit 4c4d117 into develop Jun 11, 2024
16 checks passed
@lispc lispc deleted the audit_memory_copy branch June 11, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
crate-zkevm-circuits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DreamWuGit @lispc