New Batch Circuit PI Integration Debug Fixes #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lispc
added a commit
that referenced
this pull request
Jul 16, 2024
* with example code Signed-off-by: noelwei <[email protected]> * refactor recursion circuit from example Signed-off-by: noelwei <[email protected]> * Rename aggregation circuit to batch circuit * Revert unintended root circuit changes * Revert unintended root circuit changes * Add parent state and hash to batch hash * refactoing Signed-off-by: noelwei <[email protected]> * Add additional context fields to batch hash * fix instance assign Signed-off-by: noelwei <[email protected]> * add unittest Signed-off-by: noelwei <[email protected]> * fix and pass test Signed-off-by: noelwei <[email protected]> * Remove skipped_l1_message_bitmap * Add back additional fields in batch header * Add checks for chunk-derived values against context batch header * Adjust schema for batch hash * Adjust hash components and constraints for batch hash * Adjust batch circuit pi order * Adjust CircuitExt impl * Comment definition * refactoring to support additional PI Signed-off-by: noelwei <[email protected]> * fix rng Signed-off-by: noelwei <[email protected]> * Add copy constraints for chunk-level preimage against public input * adjust comment * Add instance constraints for batch hash and its preimage * preliminary changes * main entry for prover Signed-off-by: noelwei <[email protected]> * prune and fmt code Signed-off-by: noelwei <[email protected]> * util for splitting h256 into (hi, lo) field elements * Resolve compilation issues * Resolve compilation issue * Resolve compilation issues * Resolve compilation issue * Correct h256 spliting * compilation fix and batch header's hash (test) * add new layers * prune separated recursion prover Signed-off-by: noelwei <[email protected]> * WIP: implement for bundle proving Signed-off-by: noelwei <[email protected]> * fmt and export more fields from prover * add missing field * export required fields * fields accessible from dependent crate * add pk testing in recursion process Signed-off-by: noelwei <[email protected]> * enhance test Signed-off-by: noelwei <[email protected]> * trivial fixings Signed-off-by: noelwei <[email protected]> * New Batch Circuit PI Integration Debug Fixes (#1357) * Exclude accumulators * Correct hash field indexing * Remove old batch hash instance constraints * Remove old public input constraints with accumulators and snarks input * Limit number of max snarks * Limit circuit capacity * Increase k * Increase k * Increase k * Remove old accumulator logic and debug flags * Correct import * fmt * Temporarily exclude decoder * Filter equality constraints * Recover constraint * Add debug output * Correct borrowing * Add debug flag * Add debug flags * Adjust debug flag * Adjust debug flags * Correct hash export * Remove debug flags * Recover DecoderConfig subcomponent * clippy * fmt and clippy happy * fix typos --------- Co-authored-by: Rohit Narurkar <[email protected]> * add batch header to batch proof * remove unnecessary fields * remove unneccessary fields * Recover batch circuit accumulator * fmt * clippy: * Remove feature tag * renaming config Signed-off-by: noelwei <[email protected]> * layer6 after layer5 * gen_batch_proof does not need generic * Refactor batch hash fn for batch header * clippy and fmt * more updates * WIP: updating recursion circuit Signed-off-by: noelwei <[email protected]> * Remove decoder config * WIP: update recursion circuit Signed-off-by: noelwei <[email protected]> * pass recursion-recursion test Signed-off-by: noelwei <[email protected]> * fix compilation Signed-off-by: noelwei <[email protected]> * rename bundle proof sufix Signed-off-by: noelwei <[email protected]> * fix bundle issue Signed-off-by: noelwei <[email protected]> * make batch_hash public * more fixing on bundle entries Signed-off-by: noelwei <[email protected]> * wip: bundle proof Signed-off-by: noelwei <[email protected]> * fmt and inline doc * Standalone BatchHeader Constructor (#1362) * Create standalone constructor for batch header * Recover decoder config subcomponent * corresponding changes to prover --------- Co-authored-by: Rohit Narurkar <[email protected]> * bump version * add sanity checks between infra/circuits * fix: degrees from layer 3 to 6 * cleanup, doc * fix(doc): additional public inputs are not unchanged (withdraw root) --------- Signed-off-by: noelwei <[email protected]> Co-authored-by: Ray Gao <[email protected]> Co-authored-by: Rohit Narurkar <[email protected]> Co-authored-by: Rohit Narurkar <[email protected]> Co-authored-by: Zhang Zhuo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change