-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: add another bytecode circuit to improve super circuit capacity #1368
Conversation
change assign_exec_step input to also include block and call. Inside SameContextGadget, alloc the cell and do assignment. |
after included block and call , exec_step no need to change as got enough information already. |
I think it is much cleaner to add a |
looking at it today. |
…evm-circuits into bytecode_refactor
add comment for stable sort helper explicitly (5e840fa) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary check done. I have some suggestions, some nit-picks and some opinions. Let me know what your thoughts are
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! :)
Description
details of this PR targets to implement
find_two_closest_subset
to dynamic split bytecodes into two listsbytecode_map
to get which bytecode circuit is belong to.min_num_rows_block_subcircuits
by BytecodeCircuit::min_num_rows_blockdual_bytecode
to enable/disable two bytecode circuit side by side functionality.