conditional encode

[roynalnaruto]

conditional encoding of batch -> blob

[lispc]

picked to #1396

[lispc]

Do we need another review?

[noel2004]

Everything looks good except for the blob_circuit_completeness test is blanked. What do we need to restore it?

[roynalnaruto]

@noel2004

except for the blob_circuit_completeness test is blanked

What do you mean?

The only test under blob_circuit_completeness that I have disabled currently is the "full blob" test, i.e. a batch that when encoded produces exactly 4096 * 31 bytes. The reason to comment it out is that, after prepending the single byte (enableEncoding), the present test fails (as it produces +1 byte than "full").

We need to change batch274 such that the assertion of "full" blob is still satisfied with this new structure of blob.

[lispc]

where is the logic to assert_eq!(decode(blob), compute_batch_bytes(chunk_infos))?

[roynalnaruto]

@lispc

where is the logic to assert_eq!(decode(blob), compute_batch_bytes(chunk_infos))?

We might need to add more sanity checks