Update decoder #589
Merged
Update decoder #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haerdib
force-pushed
the
bh/udpate-decoder
branch
from
0138ac6
to
1b40f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exchanges the encoder and decoder with a no-std version of
scale-decodeandscale-encodefrom parity.Check out:
Open issue for possible upstream merge: paritytech/scale-decode#25
For scale-bit there's an open PR and will hopefully be merged upstream soon: paritytech/scale-bits#2
Changes are mostly just copy paste from parity. The file & commit should be documented in the file header comment.
In a second step the events and error decoding will be adapted where sensible.
Preparatory step for #564