Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Philipp A. <[email protected]>
  • Loading branch information
ilan-gold and flying-sheep authored Oct 25, 2024
1 parent f0b7e7e commit a06675a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions src/anndata/compat/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ class Empty:
| tuple[IndexRest, Index1D]
| tuple[Index1D, Index1D, EllipsisType]
| tuple[EllipsisType, Index1D, Index1D]
| tuple[Index1D, EllipsisType, Index1D]
| scipy.sparse.spmatrix
| SpArray
)
Expand Down
9 changes: 5 additions & 4 deletions tests/test_backed_sparse.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,11 @@ def test_backed_indexing(
@pytest.mark.parametrize(
"indexing_func",
[
lambda x: (Ellipsis, slice(0, 10)),
lambda x: (slice(0, 10), Ellipsis),
lambda x: (slice(0, 10), slice(0, 10), Ellipsis),
lambda x: (Ellipsis, slice(0, 10), slice(0, 10)),
(..., slice(0, 10)),
(slice(0, 10), ...),
(slice(0, 10), slice(0, 10), ...),
(..., slice(0, 10), slice(0, 10)),
(slice(0, 10), ..., slice(0, 10)),
],
ids=["obs-ellipsis", "var-ellipsis", "obs-var-ellipsis", "ellipsis-obs-var"],
)
Expand Down

0 comments on commit a06675a

Please sign in to comment.