Fix: Large number of dataframe columns (H5py Attr Limit) #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
- Coverage 86.68% 84.18% -2.50%
==========================================
Files 37 37
Lines 5932 5937 +5
==========================================
- Hits 5142 4998 -144
- Misses 790 939 +149
|
ilan-gold
reviewed
Aug 8, 2024
src/anndata/compat/__init__.py
Outdated
| # actually 64kb is the limit, but this should be a conservative estimate | ||
| if name in f: | ||
| # TODO: One possible solution is to delete the group and recreate it | ||
| raise ValueError( |
There was a problem hiding this comment.
write_elem is idempotent for the same key
anndata/src/anndata/_io/specs/registry.py
Lines 349 to 350 in 0302f23
meeseeksmachine
pushed a commit
to meeseeksmachine/anndata
that referenced
this pull request
Aug 8, 2024
ilan-gold
pushed a commit
that referenced
this pull request
Aug 8, 2024
…Limit) (#1582) Co-authored-by: Selman Özleyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ivirshup @brainfo,
This PR solves #874. I had a chat with h5py people and this was the simplest workaround they recommended. They also have no idea why it works. See h5py/h5py#2311 (comment).
Done: