Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-concat-on-disk-examples #1161

Merged
merged 10 commits into from
Oct 5, 2023
Merged

Add-concat-on-disk-examples #1161

merged 10 commits into from
Oct 5, 2023

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Oct 5, 2023

REST API docs: https://api.cellxgene.cziscience.com/curation/ui/#/

Uses a simpler version of https://gist.github.com/ivirshup/f1a1603db69de3888eacb4bdb6a9317a (maybe they also changed the schema since then)

@flying-sheep flying-sheep added this to the 0.10.0 milestone Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1161 (9bf0b30) into main (afc5930) will increase coverage by 0.22%.
The diff coverage is 84.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1161      +/-   ##
==========================================
+ Coverage   82.58%   82.81%   +0.22%     
==========================================
  Files          36       36              
  Lines        5364     5364              
==========================================
+ Hits         4430     4442      +12     
+ Misses        934      922      -12     
Files Coverage Δ
anndata/_core/anndata.py 83.47% <ø> (ø)
anndata/experimental/merge.py 91.28% <84.61%> (+3.58%) ⬆️

... and 2 files with indirect coverage changes

@flying-sheep
Copy link
Member Author

@selmanozleyen We don’t have the overwrite argument in other commands. Is there a specific reason why you included it?

@selmanozleyen
Copy link
Member

selmanozleyen commented Oct 5, 2023

@selmanozleyen We don’t have the overwrite argument in other commands. Is there a specific reason why you included it?

@flying-sheep
Ignore my previous message please. Sorry I confused the branches. I just wanted it to have that option as only taking filenames seemed too restrictive. But in theory the user can give zarr/h5py objects as input too so it shouldn't be a problem.

@ivirshup
Copy link
Member

ivirshup commented Oct 5, 2023

Made some minor changes:

  • concat_on_disk now errors if there are no objects to concatenate (like ad.concat, pd.concat, xr.concat, np.concatenate)
  • concat_on_disk now errors if out_file's parent directory does not exist (like anndata.write_h5ad, pd.DataFrame.to_csv)

@ivirshup ivirshup merged commit 9e0e9f1 into main Oct 5, 2023
13 checks passed
@ivirshup ivirshup deleted the add-concat-on-disk-examples branch October 5, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

“How to” example for concat_on_disk
3 participants