Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): lazy chunking respects -1 #1743

Merged
merged 9 commits into from
Nov 8, 2024
Merged

(fix): lazy chunking respects -1 #1743

merged 9 commits into from
Nov 8, 2024

Conversation

ilan-gold
Copy link
Contributor

@ilan-gold ilan-gold commented Nov 7, 2024 •
edited
Loading

  • Noticed while creating the screenshot tutorial for the announcement
  • Tests added
  • Release note added (or unnecessary)

@ilan-gold ilan-gold added this to the 0.11.1 milestone Nov 7, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.52%. Comparing base (6ae9de8) to head (4dc9d12).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1743      +/-   ##
==========================================
- Coverage   86.99%   84.52%   -2.48%     
==========================================
  Files          40       40              
  Lines        6053     6053              
==========================================
- Hits         5266     5116     -150     
- Misses        787      937     +150
Files with missing lines Coverage Δ
src/anndata/_io/specs/lazy_methods.py 100.00% <100.00%> (ø)
src/anndata/_io/specs/registry.py 95.45% <ø> (-0.57%) ⬇️

... and 9 files with indirect coverage changes

@ilan-gold ilan-gold changed the title (fix): lazy chunking respects -1 + proper data/indices caching (fix): lazy chunking respects -1 Nov 8, 2024
@ilan-gold ilan-gold marked this pull request as ready for review November 8, 2024 11:24
flying-sheep
flying-sheep approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just one minor code style issue

src/anndata/_io/specs/lazy_methods.py Outdated Show resolved Hide resolved
@ilan-gold ilan-gold enabled auto-merge (squash) November 8, 2024 17:17
@ilan-gold ilan-gold merged commit 44ad42a into main Nov 8, 2024
15 checks passed
@ilan-gold ilan-gold deleted the ig/fix_chunking branch November 8, 2024 17:46
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Nov 8, 2024
@ilan-gold @meeseeksmachine
Backport PR scverse#1743: (fix): lazy chunking respects -1
56fa994
@meeseeksmachine meeseeksmachine mentioned this pull request Nov 8, 2024
Merged
ilan-gold added a commit that referenced this pull request Nov 11, 2024
@meeseeksmachine @ilan-gold
Backport PR #1743: (fix): lazy chunking respects -1 (#1750)
1db37e8 
Co-authored-by: Ilan Gold <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flying-sheep flying-sheep flying-sheep approved these changes

Assignees
No one assigned
Labels
Bug 🐛 skip-gpu-ci type: dask array
Projects
None yet
Milestone
0.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ilan-gold @flying-sheep