Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize Nones #999

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Serialize Nones #999

wants to merge 18 commits into from

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Jun 7, 2023

Rendered release notes

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (8e9eb88) to head (2d2ca32).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #999      +/-   ##
==========================================
- Coverage   86.99%   84.53%   -2.46%     
==========================================
  Files          40       40              
  Lines        6045     6054       +9     
==========================================
- Hits         5259     5118     -141     
- Misses        786      936     +150     
Files with missing lines Coverage Δ
src/anndata/_io/specs/methods.py 88.93% <100.00%> (-0.17%) ⬇️
src/anndata/_io/specs/registry.py 95.40% <ø> (-0.63%) ⬇️

... and 6 files with indirect coverage changes

@flying-sheep flying-sheep changed the title Save Nones Serialize Nones Jun 7, 2023
@flying-sheep flying-sheep marked this pull request as ready for review June 7, 2023 13:23
@ivirshup
Copy link
Member

As discussed, I don't want to change the on-disk format in the next release. So I'd hold off on this until at least 0.11.

@flying-sheep flying-sheep modified the milestones: 0.10.0, 0.11.0 Jul 10, 2023
@flying-sheep
Copy link
Member Author

Since 0.10 is released, we can document and then merge this, right?

@ivirshup
Copy link
Member

ivirshup commented Oct 6, 2023

I would like to have proposals for all disk format changes written up and discussed with other implementers before merging them to main.

@flying-sheep
Copy link
Member Author

Sure, we can use this PR as reference implementation.

Which other implementers are there? Is there a channel with the relevant people on some communication medium?

@ivirshup ivirshup modified the milestones: 0.11.0, 0.12.0 Aug 8, 2024
@alam-shahul
Copy link

Hi there, I feel that this is an important feature/bug fix, I was wondering if there were plans to merge this anytime soon/if it's possible to help.

@flying-sheep flying-sheep changed the base branch from main to test-io-roundtrip October 1, 2024 14:19
Base automatically changed from test-io-roundtrip to main October 1, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.write does not save None values
3 participants