-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend roundtrip tests #107
Conversation
@ivirshup Is it okay that I split up your roundtrip tests into different files? I split them up because if something went wrong during a roundtrip test, it was hard to know which slot was causing the issue. Also, while |
👍
Up to you. I found this quite useful since it's shared assumptions across tests. Plus this is something that should be true in both cases. If the InMemory case fails and the HDF5 one doesn't, then it was easy to tell the issue was with conversion of InMemory to HDF5 |
* use validate aligned array instead of matrix * refactor validate_aligned_array * update package docs * add has_row_names to utils * skip seurat converter for now * remove outdated tests * refactor roundtrip tests * remove roundtrip tests (will be added back in #107) * add extra line * comment out seurat object example
Changes:
write_h5ad
-read_h5ad
tests by @ivirshupNote: