Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add authors #113

Merged
merged 2 commits into from
Sep 19, 2023
Merged

add authors #113

merged 2 commits into from
Sep 19, 2023

Conversation

rcannood
Copy link
Collaborator

I added @ivirshup, @bschilder and @csangara to the Authors@R.

@bschilder mentioned he'd be happy to take up a role as co-author, whereas @ivirshup and @csangara preferred being listed as a contributor.

@bschilder, @ivirshup, @csangara: Can you verify your author details in the DESCRIPTION file?

@lazappi, @mtmorgan: Are you okay with @bschilder being added as a co-author of the package?

@bschilder
Copy link
Collaborator

@bschilder, @ivirshup, @csangara: Can you verify your author details in the DESCRIPTION file?

Looks good to me, thanks!

bschilder
bschilder approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@bschilder bschilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing officially

@rcannood
Copy link
Collaborator Author

Going to merge this since the hackathon ended :)

@rcannood rcannood merged commit 7c48007 into main Sep 19, 2023
7 checks passed
@rcannood rcannood deleted the add_hackathon_authors branch September 19, 2023 15:02
lazappi added a commit that referenced this pull request Nov 28, 2023
@lazappi
Merge remote-tracking branch 'origin/main' into add_uns
9f6452c 
* origin/main:
  remove helper function that's only used once (#130)
  add authors (#113)
  suppress warnings in vignette (#127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LouiseDck LouiseDck LouiseDck approved these changes

@bschilder bschilder bschilder approved these changes

@csangara csangara csangara approved these changes

@ivirshup ivirshup ivirshup approved these changes

@lazappi lazappi Awaiting requested review from lazappi

@mtmorgan mtmorgan Awaiting requested review from mtmorgan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rcannood @bschilder @ivirshup @csangara @LouiseDck