Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from_Seurat updates #118

Merged
merged 12 commits into from
Sep 19, 2023
Merged

from_Seurat updates #118

merged 12 commits into from
Sep 19, 2023

Conversation

csangara
Copy link
Collaborator

@csangara csangara commented Sep 19, 2023

From #60:

  • Only support single-assays when converting to "AbstractAnnData".
  • When a Seurat object has >1 assay, tell the user the Default assay is being used.
  • Also allow the user to select which assay they want to use (with assay parameter)
  • Turn each matrix element within the selected assay into layers (counts, data, scaled.data).
  • Set X as counts matrix element by default, but also allow the user the option of setting X=NULL or X=c('counts', 'data', 'scale.data')

Still to do:

  • obsm / varm

@rcannood
Copy link
Collaborator

@csangara Can you run styler::style_pkg()?

You can also add Rscript -e 'styler::styke_pkg()' to your .git/hooks/pre-commit to automate this step for you.

R/Seurat.R Outdated Show resolved Hide resolved
Co-authored-by: Robrecht Cannoodt <[email protected]>
@csangara
Copy link
Collaborator Author

Ok, thanks for the tip! I keep running it manually but I guess I forgot in the most recent commit.

@rcannood rcannood merged commit d1567ae into main Sep 19, 2023
4 of 7 checks passed
@rcannood rcannood deleted the issue-60-from-seurat branch September 19, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants