Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable obs and var roundtrip tests with factor, factor_ordered and logical #146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

re-enable obs and var roundtrip tests with factor, factor_ordered and logical #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9db34f5
re-enable obs and var roundtrip tests with factor, factor_ordered and…
rcannood Dec 2, 2023
df91844
Merge remote-tracking branch 'origin/main' into test_roundtrip_obsvar…
rcannood Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/testthat/test-roundtrip-obsvar.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@

# TODO: re-enable tests
test_names <- test_names[!grepl("_with_nas", test_names)]
# TODO: re-enable tests
test_names <- test_names[!test_names %in% c("factor", "factor_ordered")]
# TODO: re-enable tests
test_names <- test_names[test_names != "logical"]
# # TODO: re-enable tests
# test_names <- test_names[!test_names %in% c("factor", "factor_ordered")]

Check warning on line 11 in tests/testthat/test-roundtrip-obsvar.R

View workflow job for this annotation

GitHub Actions / lint 

file=tests/testthat/test-roundtrip-obsvar.R,line=11,col=3,[commented_code_linter] Commented code should be removed.
# # TODO: re-enable tests
# test_names <- test_names[test_names != "logical"]

Check warning on line 13 in tests/testthat/test-roundtrip-obsvar.R

View workflow job for this annotation

GitHub Actions / lint 

file=tests/testthat/test-roundtrip-obsvar.R,line=13,col=3,[commented_code_linter] Commented code should be removed.

for (name in test_names) {
test_that(paste0("roundtrip with obs and var '", name, "'"), {
Expand Down
Loading