Fix xenium default value and add deprecation warning #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is AI generated (Copilot Workspace). Related to #184 Revert the default value of `cells_as_circles` to `True` and add a deprecation warning. * Change the default value of the `cells_as_circles` parameter to `None` in the `xenium` function. * Add a deprecation warning indicating that the default will change to `False` in the next release. * Add logic to set `cells_as_circles` to `True` if it is `None` and display the deprecation warning. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/scverse/spatialdata-io/issues/184?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is AI generated (Copilot Workspace).
Related to #184
Revert the default value of
cells_as_circlestoTrueand add a deprecation warning.cells_as_circlesparameter toNonein thexeniumfunction.Falsein the next release.cells_as_circlestoTrueif it isNoneand display the deprecation warning.For more details, open the Copilot Workspace session.