Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERSCOPE: adding feature_key attribute for points #210

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

quentinblampey
Copy link
Contributor

Minor (but useful) PR: simply passing "gene" to the feature_key argument when parsing the points.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.50%. Comparing base (54da345) to head (cff4896).
Report is 202 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   35.91%   45.50%   +9.59%     
==========================================
  Files          19       22       +3     
  Lines        1715     2149     +434     
==========================================
+ Hits          616      978     +362     
- Misses       1099     1171      +72     
Files with missing lines Coverage Δ
src/spatialdata_io/_constants/_constants.py 100.00% <100.00%> (ø)
src/spatialdata_io/readers/merscope.py 24.06% <ø> (-0.94%) ⬇️

... and 4 files with indirect coverage changes

@LucaMarconato
Copy link
Member

Thanks! I noticed I had made a mistake in the changelog; I fixed it.

@LucaMarconato LucaMarconato merged commit bc17abc into scverse:main Sep 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants