Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(release): add CI for releasing and testing #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CodeLieutenant
Copy link

@CodeLieutenant CodeLieutenant commented Jan 20, 2025

  • Adding GitHub Actions for Building and Testing
  • Adding GitHub Actions for Releasing
  • Dockerfile updated to allow building and publishing to DockerHub
  • Makefile up the the standard with gemini
  • Dependabot to update cargo modules and GitHub actions

@CodeLieutenant CodeLieutenant added the enhancement New feature or request label Jan 20, 2025
@CodeLieutenant CodeLieutenant self-assigned this Jan 20, 2025
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@vponomaryov
Copy link
Collaborator

@CodeLieutenant left to fix the tag matching, everything else LGTM

@CodeLieutenant
Copy link
Author

@CodeLieutenant left to fix the tag matching, everything else LGTM

What should I do with -scylladb suffix in tags. docker images will have that in the version. Should it be stripped out?

@vponomaryov
Copy link
Collaborator

@CodeLieutenant left to fix the tag matching, everything else LGTM

What should I do with -scylladb suffix in tags. docker images will have that in the version. Should it be stripped out?

The latte project is a fork of another upstream one.
The upstream one has the same versioning without this suffix.
So, we do have suffix to distinguish the source.

Keep it for now.

@CodeLieutenant
Copy link
Author

@CodeLieutenant left to fix the tag matching, everything else LGTM

What should I do with -scylladb suffix in tags. docker images will have that in the version. Should it be stripped out?

The latte project is a fork of another upstream one. The upstream one has the same versioning without this suffix. So, we do have suffix to distinguish the source.

Keep it for now.

I kept it.

Also updated all github actions to use maintained setup-rust toolchain action

@CodeLieutenant CodeLieutenant marked this pull request as ready for review January 25, 2025 21:14
Copy link
Collaborator

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, squash changes into one commit (move second commit changes to the first one.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants