scylla-node: fix scylla_setup call #344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing --no-cpuscaling-setup and --no-fstrim-setup (we explicitly setup these later in the play)
and make sure to always call `scylla_setup` - with the parameters we call it
it should be safe to call it even when scylla server is already running.
We also don't need to give '--nic {{ scylla_nic }} --setup-nic-and-disks' parameters
because they are canceled by --no-sysconfig-setup at the end of the command line
and because we are going to call scylla_sysconfig_setup later in the play explicitly.
Fixes scylladb#339
Signed-off-by: Vlad Zolotarov <[email protected]>
Signed-off-by: Vlad Zolotarov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing --no-cpuscaling-setup and --no-fstrim-setup (we explicitly setup these later in the play) and make sure to always call
scylla_setup- with the parameters we call it it should be safe to call it even when scylla server is already running.We also don't need to give '--nic {{ scylla_nic }} --setup-nic-and-disks' parameters because they are canceled by --no-sysconfig-setup at the end of the command line and because we are going to call scylla_sysconfig_setup later in the play explicitly.
Fixes #339