Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs the
ruff
linting and formatting (which usesblack
) across the DRP. Where it couldn't apply automatic fixes, I tried to resolve all the linting errors as best I could. The linting errors fell into the following categories:from x import *
- I tried to resolve these as best I could.except:
intry
block - I changed these toexcept Exception:
to catch generally but that shouldn't be done either. I wasn't sure what exception to catch on.gmosMethod
andvimosMethod
- These modules don't seem used anymore. Some functions referenced in these do not exist.variable xxx is defined but unused
, andvariable xxx undefined
- I commented out these lines to keep the original line, in case these should be in.core/fluxcal.py
- these still need to be resolved. Not sure what to do here? See the Action error log. Looks like this is a straight IDL ports. Maybe missing functions?I have turned on the
ruff
linting in the Github Action workflow, so it will run on every commit now. If it finds errors it will fail and they'll need to be resolved so the checks pass, before we can merge any PR.@ajmejia you may want to do some spot checks to make sure I didn't mess anything up