Make RegexGenerator generate unlimited regexes even when enforce_uniqueness=True
#753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fealho
changed the title
RegexGenerator generate unlimited regexes when enforce_unique=True
fealho
changed the title
RegexGenerator generate unlimited regexes when enforce_unique=TrueRegexGenerator generate unlimited regexes even when enforce_uniqueness=True
fealho
force-pushed
the
issue-749-regex-generator
branch
from
d7f7302 to
a66edd0
Compare
fealho
force-pushed
the
issue-749-regex-generator
branch
from
a66edd0 to
f1cc267
Compare
fealho
requested review from
pvk-developer,
R-Palazzo and
frances-h
and removed request for
a team and
pvk-developer
frances-h
approved these changes
Jan 18, 2024
Comment on lines
195
to
196
| self.reset_randomization() | ||
| remaining = self.generator_size |
There was a problem hiding this comment.
Just out of curiosity, why do we warn the user and request them to reset randomization if we do it here for them anyways?
R-Palazzo
reviewed
Jan 18, 2024
rdt/transformers/text.py
Outdated
|
|
||
| while len(reverse_transformed) < sample_size: | ||
| remaining_samples = sample_size - len(reverse_transformed) | ||
| if dtype == int: |
There was a problem hiding this comment.
Do we need the while boucle for the int case? It seems likely to resolve in one iteration
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 1960 1975 +15
=========================================
+ Hits 1960 1975 +15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86ayz97gr, Resolve #749