RegexGenerator gives a confusing message: # of possibilities are shown as an imaginary number #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+166
to
170
| LOGGER.info( | ||
| "The data has %s rows but the regex for '%s' can only create %s unique values." | ||
| " Some values in '%s' may be repeated.", | ||
| sample_size, self.get_input_column(), self.generator_size, self.get_input_column() | ||
| ) |
There was a problem hiding this comment.
We could do:
message = (
f"..."
f"..."
)But it is actually fine to have it as it is right now; The reason why, f-string gets 'compiled' always, meanwhile this way of string formatting gets generated only when called, which means that it will be generated only when logger is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86ayz967f
Resolve #748
I didn't use f-string formatting because it was raising this lint warning for info message:
rdt/transformers/text.py:166:12: W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)Also you can see with this screenshot of the code of
step to reproducethat we now print real values.