Transition from using setup.py to pyproject.toml to specify project metadata #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amontanez24
reviewed
Mar 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 16 -2
Lines 2063 1993 -70
=========================================
- Hits 2063 1993 -70 ☔ View full report in Codecov by Sentry. |
pvk-developer
requested changes
Mar 4, 2024
rdt/__init__.py
Outdated
| setattr(addon_target, addon_name, addon) | ||
|
|
||
|
|
||
| _find_addons() |
There was a problem hiding this comment.
This code has to stay! 😅 Otherwise enterprise addons won't work
There was a problem hiding this comment.
Good catch, thanks! Updated in f332d2d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86azg1ghp
Resolve #763