Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.13 #926

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Add support for Python 3.13 #926

merged 8 commits into from
Jan 15, 2025

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Jan 9, 2025

Addresses #899

CU-86b2mqe0j

@rwedge rwedge force-pushed the issue-899-support-python-313 branch from 6e3cb39 to 0aef337 Compare January 10, 2025 20:11
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0f5e910) to head (33237e4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #926   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         2233      2233           
=========================================
  Hits          2233      2233           
Flag Coverage Δ
integration 82.93% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwedge rwedge requested review from amontanez24 and fealho January 10, 2025 21:27
@rwedge
Copy link
Contributor Author

rwedge commented Jan 10, 2025

The required git checks should update from unit (macos-latest, 3.12) and integration (macos-latest, 3.12) to unit (macos-latest, 3.13), etc

@sdv-team
Copy link
Contributor

@sdv-team
Copy link
Contributor

Task linked: CU-86b2mqe0j RDT - Support Python 3.13 #899

pyproject.toml Outdated
@@ -48,7 +53,7 @@ dependencies = [
rdt = { main = 'rdt.cli.__main__:main' }

[project.optional-dependencies]
copulas = ['copulas>=0.12.0',]
copulas = ['copulas@git+https://[email protected]/sdv-dev/copulas.git',]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can wait to merge this until we release copulas

pyproject.toml Outdated
@@ -48,7 +53,7 @@ dependencies = [
rdt = { main = 'rdt.cli.__main__:main' }

[project.optional-dependencies]
copulas = ['copulas>=0.12.0',]
copulas = ['copulas@git+https://[email protected]/sdv-dev/copulas.git',]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwedge Can we point this to the copulas release candidate to see if it passes?

@rwedge rwedge requested a review from amontanez24 January 15, 2025 21:16
@rwedge rwedge merged commit b92b8e0 into main Jan 15, 2025
57 checks passed
@rwedge rwedge deleted the issue-899-support-python-313 branch January 15, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants