Resolve pomegranate import issues #701
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #701 +/- ##
==========================================
+ Coverage 94.44% 94.88% +0.43%
==========================================
Files 106 106
Lines 4103 4103
==========================================
+ Hits 3875 3893 +18
+ Misses 228 210 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tasks.py
Outdated
| pomegranate_deps = ' '.join(minimum_pomegranate_versions) | ||
| c.run(f'python -m pip install {install_deps}') | ||
| c.run(f'python -m pip install --force-reinstall --no-cache-dir {pomegranate_deps}') |
There was a problem hiding this comment.
perhaps the pomegranate logic should only be run if minimum_pomegranate_versions isn't empty
There was a problem hiding this comment.
I think we can follow up with @kveerama to see if we want to make further changes like removing pomegranate completely but the solution LGTM!
|
@amontanez24 I can't merge due to |
Removed, good catch! |
This PR fixes #630 by switching to pomegranate 0.15 and updating the
BNLikelihoodandBNLogLikelihoodmetrics to prompt the user to installpomegranateviapip install sdmetrics[pomegranate]instead ofpip install pomegranate.pip install pomegranatewas installing pomegranate version 1.x which breaks the API we use, as seen in #642.