Add possible solutions to fix text overrun #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+118
to
+123
| <b>1. Changing MainWindow.fxml</b> | ||
|
|
||
| Remove `prefHeight` for `VBox`: | ||
| ```xml | ||
| <VBox fx:id="dialogContainer" prefWidth="388.0" /> | ||
| ``` |
There was a problem hiding this comment.
Maybe an explanation like:
This modification removes the preferred height setting for the VBox container. By not specifying a prefHeight, the VBox is allowed to expand vertically as needed based on its contents. This helps accommodate labels that might need more vertical space due to wrapped text, preventing the text from being cut off and ending with ....Would be appropriate so that students know the impacts of the changes they are making.
Comment on lines
+125
to
+130
| <b>2. Changing DialogBox.fxml</b> | ||
|
|
||
| Set `minHeight` for `Label`: | ||
| ```xml | ||
| <Label fx:id="dialog" text="Label" wrapText="true" minHeight="-Infinity"/> | ||
| ``` |
There was a problem hiding this comment.
For this change, an explanation along the lines of:
This setting allows the label to have no minimum height constraint, meaning it can shrink or expand vertically as much as needed. This flexibility ensures that if the text wrapped within the label requires more height due to wrapping, the label can expand to fit this text without truncating it. This change is particularly useful in ensuring that all content of the label is visible, regardless of the amount of text.Would be fitting.
There was a problem hiding this comment.
Thank you for the suggestion, this issue has been resolved in PR #44
|
Let's close this, as #44 has been merged already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #22
Another alternative (and more concise solution) for this is in PR #44