Skip to content

Implements feature based perf instrumentation comparision #2642

Implements feature based perf instrumentation comparision

Implements feature based perf instrumentation comparision #2642

Triggered via pull request July 9, 2023 11:45
Status Success
Total duration 24s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

pre-commit.yml

on: pull_request
pre-commit
15s
pre-commit
Fit to window
Zoom out
Zoom in

Annotations

21 errors and 24 warnings
[mypy] varats-core/varats/report/tef_report.py#L172: varats-core/varats/report/tef_report.py#L172
error: Function is missing a return type annotation [no-untyped-def]
[mypy] varats-core/varats/report/tef_report.py#L172: varats-core/varats/report/tef_report.py#L172
note: Use "-> None" if function does not return a value
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L150: varats/varats/experiments/vara/feature_perf_precision.py#L150
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L226: varats/varats/experiments/vara/feature_perf_precision.py#L226
error: Non-overlapping identity check (left operand type: "str", right operand type: "Literal[ProjectDomains.TEST]") [comparison-overlap]
[mypy] varats/varats/experiments/vara/feature_perf_precision.py#L293: varats/varats/experiments/vara/feature_perf_precision.py#L293
error: Function is missing a type annotation for one or more arguments [no-untyped-def]
[pylint] varats/varats/tables/feature_perf_precision.py#L67 <325>: varats/varats/tables/feature_perf_precision.py#L67
Unnecessary parens after 'elif' keyword (superfluous-parens)
[pylint] varats/varats/tables/feature_perf_precision.py#L112 <103>: varats/varats/tables/feature_perf_precision.py#L112
Variable name "gt" doesn't conform to snake_case naming style (invalid-name)
[pylint] varats/varats/tables/feature_perf_precision.py#L215 <116>: varats/varats/tables/feature_perf_precision.py#L215
Missing function or method docstring (missing-function-docstring)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L22 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L22
Unused ExperimentHandle imported from varats.experiment.experiment_util (unused-import)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L22 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L22
Unused VersionExperiment imported from varats.experiment.experiment_util (unused-import)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L34 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L34
Unused RunVaRATracedWorkloads imported from varats.experiments.vara.feature_experiment (unused-import)
[pylint] varats/varats/experiments/vara/feature_perf_precision.py#L34 <611>: varats/varats/experiments/vara/feature_perf_precision.py#L34
Unused RunVaRATracedXRayWorkloads imported from varats.experiments.vara.feature_experiment (unused-import)
[pylint] varats/varats/tables/feature_perf_precision.py#L296 <511>: varats/varats/tables/feature_perf_precision.py#L296
TODO: check, maybe we need a "very small value cut off" (fixme)
[pylint] varats/varats/tables/feature_perf_precision.py#L16 <611>: varats/varats/tables/feature_perf_precision.py#L16
Unused FeaturePerfRunner imported from varats.experiments.vara.feature_perf_runner (unused-import)
[pylint] varats/varats/tables/feature_perf_precision.py#L17 <611>: varats/varats/tables/feature_perf_precision.py#L17
Unused load_tef_report imported from varats.jupyterhelper.file (unused-import)
[pylint] varats/varats/tables/feature_perf_precision.py#L21 <611>: varats/varats/tables/feature_perf_precision.py#L21
Unused TimeReportAggregate imported from varats.report.gnu_time_report (unused-import)