You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The vertex and edge types as defined in util-networks.R are currently defined as magic numbers (historically coming from vector indices), but we should refactor them to be of type character. This way, we are able to actually "read" the vertex and edge attributes without any lookup.
Description
The vertex and edge types as defined in
util-networks.R
are currently defined as magic numbers (historically coming from vector indices), but we should refactor them to be of typecharacter
. This way, we are able to actually "read" the vertex and edge attributes without any lookup.https://github.com/se-passau/codeface-extraction-r/blob/34b9d35617e0d043d86a457b56d2ebc0a5ef02cd/util-networks.R#L31-L40
Proposed Solution
The solution should work out-of-the-box, so no changes to the test suite or any other parts of the code base are needed; that is why we use constants!
The solution is inspired by the plot module.
Possible problems
Versions
Any version as of now.
What is your opinion on the naming?
The text was updated successfully, but these errors were encountered: