Version v3.1.2 #114
Merged
Version v3.1.2 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a copy-paste error, gray-scale plotting misbehaved. This is fixed by setting proper names on the correct vectors. Thanks to @ecklbarb for pointing this out. Signed-off-by: Claus Hunsen <[email protected]>
When plotting networks using the default layout of the package 'ggraph' (i.e., 'igraph::layout_nicely'), we experienced segfaults in R. Therefore, we change the default layout to 'igraph::layout.kamada.kawai'. This essentially fixes #109. Thanks to @hechtlC for experiencing the problems and @bockthom for helping to find a solution. Signed-off-by: Claus Hunsen <[email protected]>
As we always match motifs on the vertex attribute 'type', the existing parameter to the function 'motifs.search.in.network' is removed. The test suite is adapted accordingly. Additionally, the documentation is updated. Signed-off-by: Claus Hunsen <[email protected]>
The vertex and edge types as defined in the networks module
('TYPE.AUTHOR', 'TYPE.ARTIFACT', 'TYPE.EDGES.INTRA', and
'TYPE.EDGES.INTER') are defined as magic numbers (historically coming
from vector indices). We refactor them to be of type 'character'. This
way, we are able to actually "read" the vertex and edge attributes
without any lookup from the network objects we construct.
The constants are now defined as follows:
TYPE.AUTHOR = "Author"
TYPE.ARTIFACT = "Artifact"
TYPE.EDGES.INTRA = "Unipartite"
TYPE.EDGES.INTER = "Bipartite"
As the motif identification works on numerics for the vertex encoding
(see 'igraph::subgraph_isomorphisms', method 'vf2'), the corresponding
code is adapted to transform the (now) character constants reliably back
to numerics. For this, we introduce the mapping 'MOTIF.TYPE.MAPPING' and
the function 'get.vertex.types.as.numeric'.
As we manually translate vertex and edge types to strings for display in
the plotting module, the module gets appropriate fixes and clean-ups.
Here, the legend name for author vertices is not 'TYPE.AUTHOR', but
"Developer". The behavior can be overwritten via setting
'PLOT.VERTEX.TYPE.AUTHOR' (and 'PLOT.VERTEX.TYPE.ARTIFACT',
respectively) appropriately.
This fixes #110.
Thanks to @bockthom for his numerous remarks on this change.
Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
In some places, we still use the word "developer" in our codebase, although we state in the contribution guide that we only use "author". This is fixed by replacing the occurrences properly. Thanks to @bockthom for pointing this out. Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
Various minor and major fixes and adjustments Reviewed-by: Thomas Bock <[email protected]>
Don't add lists containing one element as vertex attributes any more, but add just single vector elements. If a vertex attribute can have multiple values per vertex (e.g., active ranges), then we need to wrap the vertex-attribute vector into an individual list per vertex. This has one side effect: Vertex attributes where simply are dates are not saved in POSIXct format any more, but as UNIX timestamps (similar to edge attributes). This fixes #112. In addition, all the corresponding tests are adjusted to the new behavior. Signed-off-by: Thomas Bock <[email protected]>
The function 'get.date.from.string' does currently not handle time zones, that is, it expects every input to be in UTC, even if there is another time-zone suffix in the input. To make the user aware of that, add a notice to this function and add an additional test which makes sure that the time-zone suffix is, indeed, ignored. Signed-off-by: Thomas Bock <[email protected]>
Signed-off-by: Thomas Bock <[email protected]>
Just some small changes on comments. Signed-off-by: Thomas Bock <[email protected]>
Fix lists of vertex attributes Reviewed-by: Claus Hunsen <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
|
As we reviewed everything before, I will merge rightaway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.1.2
Changes in detail
v3.1.1...03a70f2
Changed/Improved
"type") are now a character string (e.g., "Author" or "Unipartite") (Change/Improve values of vertex-type and edge-type constants #110, 3ca6ed9)igraph::layout.kamada.kawai(Segfaults when using the 'plot.network' function #109, 9099654)get.date.from.stringdoes ignore time-zone suffixes (9a51877)Fixed