Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vertex attributes (updated) #93

Merged
merged 34 commits into from
Feb 19, 2018
Merged

Add vertex attributes (updated) #93

merged 34 commits into from
Feb 19, 2018

Commits on Dec 21, 2017

  1. Add commit count as vertex attribute

    Add methods required to add vertex attributes to the graph.
    Add method to calculate commit count as vertex attribute
    
    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    3ca6063 View commit details
    Browse the repository at this point in the history
  2. Add further vertex attributes

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    cafa3ab View commit details
    Browse the repository at this point in the history
  3. Add author classification attribute

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    32944cb View commit details
    Browse the repository at this point in the history
  4. Minor refactoring on vertex attributes

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    fe2721c View commit details
    Browse the repository at this point in the history
  5. Fix implementation of active author range vertex attribute

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    0371351 View commit details
    Browse the repository at this point in the history
  6. Rename util-covariates.R to util-networks-covariates.R

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    39065fd View commit details
    Browse the repository at this point in the history
  7. Rename what parameter to aggregation

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    e3c6510 View commit details
    Browse the repository at this point in the history
  8. Add comments to vertex attribute methods

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    cd261ad View commit details
    Browse the repository at this point in the history
  9. Refactor code of vertex attributes

    - Rename aggregation to aggregation.level and all to project
    - Rename add.vertex.attributes.* methods to add.vertex.attribute.*
    - Rename compute.vertex.attribute.with.n2r to add.vertex.attribute
    - Rename compute.vertex.attribute to split.and.add.vertex.attribute
    - Move networks.to.ranges to util-split and
      rename it to split.data.by.networks
    - Remove explicit return statement where possible
    - Add missing documentation
    
    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    a8ca406 View commit details
    Browse the repository at this point in the history
  10. Extend add.vertex.attribute.first.activity to work on mail, commits a…

    …nd issues
    
    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    288c927 View commit details
    Browse the repository at this point in the history
  11. Add default value for missing vertex attributes

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    d7d8986 View commit details
    Browse the repository at this point in the history
  12. Improve author role classification

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    2549f2b View commit details
    Browse the repository at this point in the history
  13. Add explicit return

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    bca66be View commit details
    Browse the repository at this point in the history
  14. Add test for splitting project data

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    efd9b2d View commit details
    Browse the repository at this point in the history
  15. Add multiple tests for vertex attributes

    Add test for add.vertex.attribute
    Add test for split.and.add.vertex.attribute
    Add test for add.vertex.attribute.commit.count
    Add test for add.vertex.attribute.author.email
    Add test for add.vertex.attribute.artifact.count
    Add test for add.vertex.attribute.first.activity
    
    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    06ec950 View commit details
    Browse the repository at this point in the history
  16. Fix network attribute unit tests

    The tests were referencing to a wrong project data variable
    
    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    df52ac7 View commit details
    Browse the repository at this point in the history
  17. Fix artifact count attribute implementation

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    8ae1abf View commit details
    Browse the repository at this point in the history
  18. Add tests for network vertex attributes

    Add test for add.vertex.attribute.author.role.simple
    Add test for add.vertex.attribute.active.ranges
    
    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    b9f0bd3 View commit details
    Browse the repository at this point in the history
  19. Comments for network-covariates tests

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    3e20fb2 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2017

  1. Add more vertex attributes

    Add artifact attributes
    Add commit count based on committer
    
    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    9f53875 View commit details
    Browse the repository at this point in the history
  2. Add tests for artifact vertex attributes

    Signed-off-by: Felix Prasse <[email protected]>
    Felix Prasse committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    a002dfa View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2018

  1. Refactor tests on network attributes

    In this patch, we mainly streamline the tests on network attributes, by
    applying proper line breaks, introducing global constants, and fixing
    the accidental introduction of factors for the developer roles.
    
    This tackles some comments in PR #67.
    
    Signed-off-by: Claus Hunsen <[email protected]>
    clhunsen committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    289196a View commit details
    Browse the repository at this point in the history
  2. Update core-peripheral module

    With respect to PR #67, logging statements, line breaks, and
    capitalization in sqldf-statements are updated.
    
    Signed-off-by: Claus Hunsen <[email protected]>
    clhunsen committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    c6418c5 View commit details
    Browse the repository at this point in the history
  3. Update networks-covariates module

    With respect to PR #67, indentation, line breaks, coding flaws, and
    anything else is tackled.
    
    Adds a FIXME item regarding the first activity of an author, which will
    be tackled in an upcoming commit.
    
    Signed-off-by: Claus Hunsen <[email protected]>
    clhunsen committed Feb 14, 2018
    Configuration menu
    Copy the full SHA
    0eafcd0 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2018

  1. Fix section dividers in some files

    The section dividers always end at column 77. ;)
    
    Signed-off-by: Claus Hunsen <[email protected]>
    clhunsen committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    ac678f6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    07c85db View commit details
    Browse the repository at this point in the history
  3. Add ability to the earliest and latest data timestamps

    To get the very first and the very last activity across all data
    sources, i.e., the earliest/latest timestamp of all data sources, for a
    ProjectData object, we add a parameter 'outermost' to
    'ProjectData$get.data.timestamps' that makes this possible.
    
    Props to @bockthom for his support.
    
    Signed-off-by: Claus Hunsen <[email protected]>
    Signed-off-by: Thomas Bock <[email protected]>
    clhunsen committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    217e41c View commit details
    Browse the repository at this point in the history
  4. Extend aggregation levels for data-splitting-by-network functionality

    Formerly, we provided three different aggregation levels in the function
    'split.data.by.networks': namely, "range", "cumulative", and "project".
    We now extend and adapt this to the levels "range", "cumulative",
    "all.ranges", "project.cumulative", "project.all.ranges", and
    "complete".
    
    The various aggregation levels work as follows:
    - range: The project data will be split exactly to the time ranges
             specified by the networks' names.
    - cumulative: The project data will be split exactly to the time ranges
             specified by the networks' names, but in a cumulative manner.
    - all.ranges"}: The project data will be split exactly to the time range
             specified by the start of the first network and end of the last
             network. All data instances will contain the same data.
    - project.cumulative: The same splitting as for \code{"cumulative"}, but
             all data will start at the beginning of the project data and
             *not* at the beginning of the first network.
    - project.all.ranges: The same splitting as for \code{"all.ranges"}, but
             all data will start at the beginning of the project data and
             *not* at the beginning of the first network. All data instances
             will contain the same data.
    - complete: The same splitting as for \code{"all.ranges"}, but all data
             will start at the beginning of the project data and end at the
             end of the project data. All data instances will contain the
             same data.
    
    In this patch, we properly extend all functions and tests.
    
    Props to @bockthom for his support in parts of this patch.
    
    Signed-off-by: Claus Hunsen <[email protected]>
    Signed-off-by: Thomas Bock <[email protected]>
    clhunsen committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    52eae7f View commit details
    Browse the repository at this point in the history
  5. Add author-classification attributes based on classification result

    The function 'add.vertex.attribute.author.role' now adds author-
    classification attributes based on classification results. The function
    'add.vertex.attribute.author.role.function' is now the one using a
    classification function as a parameter.
    
    For this to work, we add the range identifier as a parameter to the
    anonymous calculation functions for adding the vertex attributes.
    
    Signed-off-by: Claus Hunsen <[email protected]>
    Signed-off-by: Thomas Bock <[email protected]>
    clhunsen committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    5242e76 View commit details
    Browse the repository at this point in the history
  6. Add 'date.offset' to possible edge attributes

    Signed-off-by: Claus Hunsen <[email protected]>
    Signed-off-by: Thomas Bock <[email protected]>
    clhunsen committed Feb 15, 2018
    Configuration menu
    Copy the full SHA
    0c1868a View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. Move 'get.commit.data' to the data module

    For better modularity, the function 'get.commit.data' is moved to the
    data module, right where it obviously belongs.
    
    Signed-off-by: Claus Hunsen <[email protected]>
    clhunsen committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    4810ac5 View commit details
    Browse the repository at this point in the history
  2. Add example on vertex attributes to showcase file

    This code originates from @flx5's PR on vertex attributes (#67).
    
    Signed-off-by: Claus Hunsen <[email protected]>
    clhunsen committed Feb 16, 2018
    Configuration menu
    Copy the full SHA
    056cd22 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. Minor fixes from review in PR #93

    This patch introduces only some minor fixes and inprovements to the
    documentation for the changes in PR #93.
    
    The most important change is the renaming of the function
    'add.vertex.attribute.commit.count' to
    'add.vertex.attribute.commit.count.helper', mainly for unambiguity and
    consistency reasons.
    
    Props to @bockthom for being that precise.
    
    Signed-off-by: Claus Hunsen <[email protected]>
    clhunsen committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    9684f39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    253433d View commit details
    Browse the repository at this point in the history