Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inspect types when resolving field marshallers for structured types #2

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

seandstewart
Copy link
Owner

  • Fixes an issue where two structured types within the same graph have conflicting attribute names, resulting in incorrect marshaller assignment for those fields.
  • Fix some issues with job duplication in CI

Fixes an issue where two structured types within the same graph have conflicting attribute names, resulting in incorrect marshaller assignment for those fields.
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.77%. Comparing base (9a9a2ba) to head (a5ddf68).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/typelib/marshals/routines.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage   96.76%   96.77%           
=======================================
  Files          21       21           
  Lines        1454     1489   +35     
  Branches      260      265    +5     
=======================================
+ Hits         1407     1441   +34     
- Misses         27       28    +1     
  Partials       20       20           
Flag Coverage Δ
unittests 96.50% <97.43%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…e original hint

This is due to type-hint rewriting for Python < 3.10.
@seandstewart seandstewart merged commit a0eda9a into main Oct 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants