Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove use of graphlib.TypeNode in type context #4

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

seandstewart
Copy link
Owner

This simplifies the work to resolve routines for fields of structured types and reduces the overall footprint of the type context.

This simplifies our resolution algorithm for structured type routines.
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.97%. Comparing base (6bd7023) to head (e4742c0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/typelib/unmarshals/routines.py 57.14% 2 Missing and 1 partial ⚠️
src/typelib/ctx.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #4      +/-   ##
==========================================
+ Coverage   96.92%   96.97%   +0.05%     
==========================================
  Files          21       21              
  Lines        1494     1486       -8     
  Branches      267      264       -3     
==========================================
- Hits         1448     1441       -7     
  Misses         27       27              
+ Partials       19       18       -1     
Flag Coverage Δ
unittests 96.70% <90.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seandstewart seandstewart merged commit 4565c0d into main Oct 26, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants