Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unwrap TypeAliasType for all nested types in a type graph #6

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

seandstewart
Copy link
Owner

  • Fixes an issue where field types would fail to resolve to an actionable marshaller/unmarshaller if they were a TypeAliasType.

- Fixes an issue where field types would fail to resolve to an actionable marshaller/unmarshaller if they were a `TypeAliasType`.
@seandstewart seandstewart force-pushed the seandstewart/type-alias-type-origin branch 3 times, most recently from 132ecb2 to 5b8f13b Compare October 30, 2024 13:21
- Ignore tag events when running `Validate`
- Ignore tag events when running `Make Documentation`
- Run `Make Documentation` on deploy
- Re-order steps in `Publish Release` to debug issue with outdated changelog in release notes.
@seandstewart seandstewart force-pushed the seandstewart/type-alias-type-origin branch from 5b8f13b to 15466cb Compare October 30, 2024 13:22
@seandstewart seandstewart self-assigned this Oct 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.84%. Comparing base (e9c0bff) to head (15466cb).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/typelib/graph.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   96.97%   96.84%   -0.13%     
==========================================
  Files          21       21              
  Lines        1488     1492       +4     
  Branches      265      267       +2     
==========================================
+ Hits         1443     1445       +2     
- Misses         27       28       +1     
- Partials       18       19       +1     
Flag Coverage Δ
unittests 96.58% <50.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seandstewart seandstewart merged commit 6d6e76d into main Oct 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants