Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle TypeAliasType within TypeContext lookups #7

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

seandstewart
Copy link
Owner

  • Resolves an issue where nested type alias types would cause a KeyError with direct lookups from the type context

- Resolves an issue where nested type alias types would cause a KeyError with direct lookups from the type context
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.50%. Comparing base (ff01211) to head (1295bed).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/typelib/py/inspection.py 53.84% 4 Missing and 2 partials ⚠️
src/typelib/ctx.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   96.84%   96.50%   -0.35%     
==========================================
  Files          21       21              
  Lines        1492     1516      +24     
  Branches      267      273       +6     
==========================================
+ Hits         1445     1463      +18     
- Misses         28       33       +5     
- Partials       19       20       +1     
Flag Coverage Δ
unittests 96.24% <72.00%> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seandstewart seandstewart merged commit bd74d29 into main Oct 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants