Skip to content

Commit

Permalink
Brotli: Don't leave errors behind if loading library failed.
Browse files Browse the repository at this point in the history
If brolti support is dynamic then it is loaded at runtime and may fail
if the library is not available. The library can be loaded even if the
user did not ask for it, for instance via SSL_CTX_new_ex() ->
ossl_comp_has_alg().
Leaving an error record can have other side effects if the user is
poping the stack and notices and aborts due it.

Use ERR_set_mark()/ ERR_pop_to_mark() to avoid leaving marks if library
loading failed.

Fixes: openssl#23558
Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
  • Loading branch information
sebastianas committed Feb 13, 2024
1 parent 0969375 commit d8e4da8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions crypto/comp/c_brotli.c
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ DEFINE_RUN_ONCE_STATIC(ossl_comp_brotli_init)
# define LIBBROTLIDEC "brotlidec"
# endif

ERR_set_mark();
brotli_encode_dso = DSO_load(NULL, LIBBROTLIENC, NULL, 0);
if (brotli_encode_dso != NULL) {
p_encode_init = (encode_init_ft)DSO_bind_func(brotli_encode_dso, "BrotliEncoderCreateInstance");
Expand Down Expand Up @@ -319,8 +320,10 @@ DEFINE_RUN_ONCE_STATIC(ossl_comp_brotli_init)
|| p_decode_error == NULL || p_decode_error_string == NULL || p_decode_is_finished == NULL
|| p_decode_oneshot == NULL) {
ossl_comp_brotli_cleanup();
ERR_pop_to_mark();
return 0;
}
ERR_pop_to_mark();
# endif
return 1;
}
Expand Down

0 comments on commit d8e4da8

Please sign in to comment.