Always enable optimizations on image loader #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaduBerinde
force-pushed
the
faster-image-loading
branch
from
7a06410 to
24c0c9c
Compare
The examples that involve textures show a noticeable delay at start in dev mode; the delay is not there in release mode. I tracked this down to the image library. This commit changes the profile for the image library and the jpg and png decoding libraries to use optimizations and disable debug assertions.
RaduBerinde
force-pushed
the
faster-image-loading
branch
from
24c0c9c to
dc79605
Compare
There was a problem hiding this comment.
I tend to think it's best to leave the dev profile alone in the crate configuration. For development, cargo profiles can always be customized via a config.toml.
I don't think anyone would be too surprised that image decoding is slow without compiler optimizations.
|
The problem is that it takes a bit of work to figure out that the image loading is what's causing slow startup times. At least one other person ran into this: #240 (comment) Should we maybe include a note somewhere in the README? |
|
Sure, feel free to add a note if you think it's helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples that involve textures show a noticeable delay at start
in dev mode; the delay is not there in release mode. I tracked this
down to the image library. This commit changes the profile for the
image library and the jpg and png decoding libraries to use
optimizations and disable debug assertions.