-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gh-pages with master changes & create some pages. #1
Conversation
Also check for the existence of globals before using them Add npm package file
Just received gh-pages fail note, will troubleshoot this. |
Did update submodules' paths, no effect, will be contacting github support for this. Sorry for rushing things around. |
It's working, you can see it on http://sudodoki.github.io/art/ (not very pretty at this moment, but still). |
Ideally this would be the same branch as master so that they can be remain consistent and easy to update. What issues are you running into with the submodules? Are you forking anything in the submodules? |
Two issues:
|
Maybe you can use bower/npm just to pull files needed & commit them into vendor folder? That will make this so much easier to keep same structure & avoid this problems. |
These projects don't have npm equivalents so there would still be upstream work to be done. Ideally we could switch these out to more modern dependencies. Could you submit a PR to master with the submodules intact and then an equivalent PR with the submodules commited into their location for gh-pages? At least that allow us to easily track upstream in master and just inline them in the gh-pages branch. The links on the index page seems to be link to the wrong subfolder since they're not relative...? |
Okay, I will fix links and do 2 PRs to master & gh-pages branches. |
This PR update gh-pages branch with latest commits + adds basic index page for root & docs folders, setups jekyll to exclude submodule *markdown files.
Checked this only locally with jekyll 1.5.1, assume gh-pages aren't being generated for fork projects.
Partially related with reactjs/react-art#3.