Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gh-pages with master changes & create some pages. #1

Closed
wants to merge 13 commits into from
Closed

Update gh-pages with master changes & create some pages. #1

wants to merge 13 commits into from

Conversation

sudodoki
Copy link

This PR update gh-pages branch with latest commits + adds basic index page for root & docs folders, setups jekyll to exclude submodule *markdown files.
Checked this only locally with jekyll 1.5.1, assume gh-pages aren't being generated for fork projects.
screenshot from 2014-04-27 15 02 57
Partially related with reactjs/react-art#3.

@sudodoki
Copy link
Author

Just received gh-pages fail note, will troubleshoot this.

@sudodoki
Copy link
Author

Did update submodules' paths, no effect, will be contacting github support for this. Sorry for rushing things around.

@sudodoki
Copy link
Author

It's working, you can see it on http://sudodoki.github.io/art/ (not very pretty at this moment, but still).
Due to issue with submodules depending recursively on submodules that use git:// links for submodules, ran into forking hell (working on straigthening this out) and decided to settle on removing submodules for now.

@sebmarkbage
Copy link
Owner

Ideally this would be the same branch as master so that they can be remain consistent and easy to update.

What issues are you running into with the submodules? Are you forking anything in the submodules?

@sudodoki
Copy link
Author

Two issues:

  1. if you're using gh-pages, your submodules should be using read-only https:// links (I did few forks to bypass that, but it leads to changes in:
  1. labeled-modules-spec submodule doesn't exist anymore link.js#8 one of the modules is gone but still dependent.
    Which results in jekyll fail.

@sudodoki
Copy link
Author

Maybe you can use bower/npm just to pull files needed & commit them into vendor folder? That will make this so much easier to keep same structure & avoid this problems.

@sebmarkbage
Copy link
Owner

These projects don't have npm equivalents so there would still be upstream work to be done. Ideally we could switch these out to more modern dependencies.

Could you submit a PR to master with the submodules intact and then an equivalent PR with the submodules commited into their location for gh-pages? At least that allow us to easily track upstream in master and just inline them in the gh-pages branch.

The links on the index page seems to be link to the wrong subfolder since they're not relative...?

@sudodoki
Copy link
Author

Okay, I will fix links and do 2 PRs to master & gh-pages branches.

@sudodoki sudodoki closed this Apr 28, 2014
@sudodoki
Copy link
Author

They're out in #3 & #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants