Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if this is defined #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

f0rr0
Copy link

@f0rr0 f0rr0 commented May 11, 2017

No description provided.

@IgorBelyayev
Copy link

@sebmarkbage This needs to be merged.

@Tredis
Copy link

Tredis commented Jan 5, 2018

@sebmarkbage Yes, this needs to be merged ASAP!

@d4l3k
Copy link

d4l3k commented Jan 29, 2018

I'm running into this issue as well with babel+webpack. Anyone have a work around?

@d4l3k
Copy link

d4l3k commented Jan 29, 2018

Turns out you can just exclude this from babel and it works just fine.

      {
        test: /\.js?$/,
        loader: 'babel-loader',
        exclude: /node_modules\/art/,
        query: {
          presets: [
            ['env', {
              loose: true
            }],
            'react'
          ],
          plugins: [
            'transform-object-rest-spread',
            'transform-class-properties'
          ]
        }
      }

@piranna
Copy link

piranna commented May 18, 2018

Can this be merged? Also, what workaround can be used if not using Webpack, only Babel?

@d4l3k
Copy link

d4l3k commented May 18, 2018

Should be able to exclude certain files using .babelrc. https://stackoverflow.com/questions/35415301/make-babel-exclude-test-files

@piranna
Copy link

piranna commented May 18, 2018

Should be able to exclude certain files using .babelrc. https://stackoverflow.com/questions/35415301/make-babel-exclude-test-files

Yeah, but was not able to make it work. Anyway, I tried what's done on this pull-request and tests are passing, that's the only thing I wanted, so it's ok for me for now, but definitely this should be merged.

@relign
Copy link

relign commented Feb 26, 2019

this should be merged

@john-angelogiannis
Copy link

Please merge this ASAP!

@bing107
Copy link

bing107 commented Mar 6, 2019

Can we please merge this?

1 similar comment
@timwuhaotian
Copy link

Can we please merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants