Make Dot11EltVendorSpecific packet extensible #4660
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4659
This commit allows the
Dot11EltVendorSpecific
packet to dispatch to its subclasses based on their OUI, with the same idiom that the parentDot11Elt
uses to select subclasses based on their ID already:scapy/scapy/layers/dot11.py
Lines 1057 to 1074 in c15a670
This is just a rough sketch, so feedback very welcome; is the approach heading in the right direction? :)